Open
Conversation
nodchip
reviewed
Feb 11, 2026
| final leftTreeDepth = maxDepth(root.left); | ||
| final rightTreeDepth = maxDepth(root.right); | ||
|
|
||
| return 1 + max(leftTreeDepth, rightTreeDepth); |
There was a problem hiding this comment.
個人的には
return max(leftTreeDepth, rightTreeDepth) + 1;
と、複雑なものを先、簡単なものを後に置くのですが、趣味の範囲だと思います。
mamo3gr
reviewed
Feb 14, 2026
|
|
||
| class Solution { | ||
| int maxDepth(TreeNode? root) { | ||
| int maxDepthHelper(TreeNode? node, int previousDepth) { |
There was a problem hiding this comment.
些末ですが、ここで定義されている時点で、スコープ的に maxDepth のヘルパーであることはほぼ自明なので、関数名から取り除いても構わないと思いました。
Suggested change
| int maxDepthHelper(TreeNode? node, int previousDepth) { | |
| int helper(TreeNode? node, int previousDepth) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題：https://leetcode.com/problems/maximum-depth-of-binary-tree/description/
次に解く問題：https://leetcode.com/problems/minimum-depth-of-binary-tree/description/